Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

chore | evaluate all entity types in interaction filters #184

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

aman-bansal
Copy link
Member

@aman-bansal aman-bansal commented Nov 23, 2023

No description provided.

@aman-bansal aman-bansal requested a review from a team as a code owner November 23, 2023 05:17
Copy link

Test Results

361 tests  ±0   361 ✔️ ±0   8s ⏱️ -2s
  66 suites ±0       0 💤 ±0 
  66 files   ±0       0 ±0 

Results for commit 802a3e7. ± Comparison against base commit 1997536.

This pull request removes 28 and adds 13 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [10] group-by-with-group-limit-and-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [11] time-aggregations
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [12] aggregations-with-multiple-groupbys-and-the-rest-deprecated
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [1] time-aggregations-space-filtered
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [2] aggregations-with-groupby-and-the-rest-deprecated
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [3] grouped-time-aggregation-with-group-limit-and-the-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [5] grouped-time-aggregation-with-group-limit
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [6] group-by-with-group-limit
…

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1997536) 81.40% compared to head (802a3e7) 81.48%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #184      +/-   ##
============================================
+ Coverage     81.40%   81.48%   +0.08%     
- Complexity     1327     1329       +2     
============================================
  Files           125      125              
  Lines          5964     5963       -1     
  Branches        490      490              
============================================
+ Hits           4855     4859       +4     
+ Misses          865      863       -2     
+ Partials        244      241       -3     
Flag Coverage Δ
unit 81.48% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aman-bansal aman-bansal merged commit 9f2aa9d into main Nov 23, 2023
9 checks passed
@aman-bansal aman-bansal deleted the aman/filter_fix branch November 23, 2023 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants