Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

chore: upgrade gradle to 8.5 #190

Merged
merged 7 commits into from
Jan 25, 2024

Conversation

patelraj0602
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@patelraj0602 patelraj0602 requested a review from a team as a code owner January 18, 2024 08:32
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f93644) 82.56% compared to head (88f64fc) 82.56%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #190   +/-   ##
=========================================
  Coverage     82.56%   82.56%           
  Complexity     1367     1367           
=========================================
  Files           125      125           
  Lines          6068     6068           
  Branches        501      501           
=========================================
  Hits           5010     5010           
  Misses          807      807           
  Partials        251      251           
Flag Coverage Δ
unit 82.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kishansairam9
kishansairam9 previously approved these changes Jan 22, 2024
@aaron-steinfeld
Copy link
Contributor

Dependencies fixed in #191

kishansairam9
kishansairam9 previously approved these changes Jan 24, 2024
@@ -1 +1 @@
CVE-2023-5678 exp:2023-11-30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this required?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is passing without this, so I don't think it is needed, remove this line

@kishansairam9 kishansairam9 dismissed their stale review January 24, 2024 09:26

by mistake approved

@patelraj0602 patelraj0602 merged commit 4145b21 into hypertrace:main Jan 25, 2024
7 checks passed
@patelraj0602 patelraj0602 deleted the gradle-upgrade branch January 25, 2024 05:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants