Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

chore(configmap): revert the config map back to helm values #194

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

skjindal93
Copy link
Contributor

No description provided.

@skjindal93 skjindal93 marked this pull request as ready for review February 28, 2024 14:00
@skjindal93 skjindal93 requested a review from a team as a code owner February 28, 2024 14:00
Copy link

Test Results

366 tests  ±0   366 ✅ ±0   9s ⏱️ ±0s
 67 suites ±0     0 💤 ±0 
 67 files   ±0     0 ❌ ±0 

Results for commit 85bc104. ± Comparison against base commit d05ac93.

This pull request removes 17 and adds 2 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (d05ac93) to head (85bc104).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #194   +/-   ##
=========================================
  Coverage     81.35%   81.35%           
  Complexity     1371     1371           
=========================================
  Files           126      126           
  Lines          6200     6200           
  Branches        524      524           
=========================================
  Hits           5044     5044           
  Misses          897      897           
  Partials        259      259           
Flag Coverage Δ
unit 81.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjindal93 skjindal93 merged commit c595ac6 into main Feb 28, 2024
9 checks passed
@skjindal93 skjindal93 deleted the revert+config+map branch February 28, 2024 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants