Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

fix(entities): enum map throws exception for empty maps #195

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

skjindal93
Copy link
Contributor

No description provided.

@skjindal93 skjindal93 requested a review from a team as a code owner March 6, 2024 08:27
Copy link

github-actions bot commented Mar 6, 2024

Test Results

366 tests  ±0   366 ✅ ±0   9s ⏱️ ±0s
 67 suites ±0     0 💤 ±0 
 67 files   ±0     0 ❌ ±0 

Results for commit 87615bf. ± Comparison against base commit c595ac6.

This pull request removes 17 and adds 2 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.35%. Comparing base (c595ac6) to head (87615bf).

Files Patch % Lines
...way/service/entity/query/ExecutionTreeBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #195   +/-   ##
=========================================
  Coverage     81.35%   81.35%           
  Complexity     1371     1371           
=========================================
  Files           126      126           
  Lines          6200     6200           
  Branches        524      524           
=========================================
  Hits           5044     5044           
  Misses          897      897           
  Partials        259      259           
Flag Coverage Δ
unit 81.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjindal93 skjindal93 merged commit f284959 into main Mar 6, 2024
8 of 9 checks passed
@skjindal93 skjindal93 deleted the fix+empty+enum+map branch March 6, 2024 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants