fix(explore): return early, if no entities

[skjindal93]

No description provided.

[github-actions]

Test Results

366 tests  ±0   366 ✅ ±0   8s ⏱️ -1s
 67 suites ±0     0 💤 ±0 
 67 files   ±0     0 ❌ ±0 

Results for commit 31f2447. ± Comparison against base commit f284959.

This pull request removes 32 and adds 17 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [10] simple-selection
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [11] grouped-time-aggregation-with-group-limit-and-the-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [12] time-aggregations-space-filtered
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [13] group-by-with-group-limit
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [14] aggregations-with-groupby-and-the-rest-deprecated
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [15] grouped-time-aggregation-with-group-limit
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [1] grouped-time-aggregation-with-group-limit-and-the-rest-with-null-value-group
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [2] grouped-time-aggregation-with-group-limit-with-null-and-nonnull-value-group
…

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.30%. Comparing base (f284959) to head (31f2447).

Files	Patch %	Lines
...rtrace/gateway/service/explore/RequestHandler.java	42.85%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #196      +/-   ##
============================================
- Coverage     81.35%   81.30%   -0.05%     
  Complexity     1371     1371              
============================================
  Files           126      126              
  Lines          6200     6205       +5     
  Branches        524      526       +2     
============================================
+ Hits           5044     5045       +1     
- Misses          897      899       +2     
- Partials        259      261       +2     

Flag	Coverage Δ
unit	81.30% <50.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aaron-steinfeld]

minor comments

[aaron-steinfeld]

nit - worth a comment explaining why we shouldn't build a query request in this case

[aaron-steinfeld]

nit - prefer .orElseThrow over .get (or move code around to avoid the direct access)

hang on - checking response format