This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
fix | fix the entity ids filter for explore if empty #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
============================================
- Coverage 81.35% 81.11% -0.24%
- Complexity 1371 1372 +1
============================================
Files 126 126
Lines 6200 6254 +54
Branches 524 525 +1
============================================
+ Hits 5044 5073 +29
- Misses 897 920 +23
- Partials 259 261 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Test Results366 tests ±0 366 ✅ ±0 8s ⏱️ -1s Results for commit 7b5630d. ± Comparison against base commit f284959. This pull request removes 32 and adds 17 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
gateway-service-impl/src/main/java/org/hypertrace/gateway/service/explore/RequestHandler.java
Outdated
Show resolved
Hide resolved
gateway-service-impl/src/main/java/org/hypertrace/gateway/service/explore/RequestHandler.java
Show resolved
Hide resolved
gateway-service-impl/src/main/java/org/hypertrace/gateway/service/explore/RequestHandler.java
Outdated
Show resolved
Hide resolved
aaron-steinfeld
approved these changes
Mar 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.