Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

fix | fix the entity ids filter for explore if empty #197

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

aman-bansal
Copy link
Member

@aman-bansal aman-bansal commented Mar 8, 2024

No description provided.

@aman-bansal aman-bansal requested a review from a team as a code owner March 8, 2024 11:32
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 81.11%. Comparing base (f284959) to head (7b5630d).

Files Patch % Lines
...rtrace/gateway/service/explore/RequestHandler.java 68.75% 18 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #197      +/-   ##
============================================
- Coverage     81.35%   81.11%   -0.24%     
- Complexity     1371     1372       +1     
============================================
  Files           126      126              
  Lines          6200     6254      +54     
  Branches        524      525       +1     
============================================
+ Hits           5044     5073      +29     
- Misses          897      920      +23     
- Partials        259      261       +2     
Flag Coverage Δ
unit 81.11% <68.75%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 8, 2024

Test Results

366 tests  ±0   366 ✅ ±0   8s ⏱️ -1s
 67 suites ±0     0 💤 ±0 
 67 files   ±0     0 ❌ ±0 

Results for commit 7b5630d. ± Comparison against base commit f284959.

This pull request removes 32 and adds 17 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [10] simple-selection
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [11] grouped-time-aggregation-with-group-limit-and-the-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [12] time-aggregations-space-filtered
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [13] group-by-with-group-limit
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [14] aggregations-with-groupby-and-the-rest-deprecated
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [15] grouped-time-aggregation-with-group-limit
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [1] grouped-time-aggregation-with-group-limit-and-the-rest-with-null-value-group
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [2] grouped-time-aggregation-with-group-limit-with-null-and-nonnull-value-group
…

♻️ This comment has been updated with latest results.

@aman-bansal aman-bansal merged commit af6e8b0 into main Mar 11, 2024
7 of 9 checks passed
@aman-bansal aman-bansal deleted the aman/fix_filters branch March 11, 2024 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants