Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

chore | adding the support of joining nodes for eds source query #204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aman-bansal
Copy link
Member

No description provided.

@aman-bansal aman-bansal requested a review from a team as a code owner June 23, 2024 04:47
Copy link

github-actions bot commented Jun 23, 2024

Test Results

368 tests  +1   368 ✅ +1   8s ⏱️ ±0s
 68 suites ±0     0 💤 ±0 
 68 files   ±0     0 ❌ ±0 

Results for commit b16a950. ± Comparison against base commit 99ef811.

This pull request removes 30 and adds 16 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.entity.query.visitor.ExecutionVisitorTest ‑ test_visit_JoinNode()
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [10] simple-aggregations
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [11] grouped-time-aggregation-with-group-limit
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [12] simple-selection
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [13] aggregations-with-multiple-groupbys-and-the-rest-deprecated
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [14] grouped-time-aggregation-with-group-limit-and-the-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [15] grouped-time-aggregation-with-group-limit-with-null-value-group
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [1] group-by-with-group-limit-and-rest
…

♻️ This comment has been updated with latest results.

.getExpressionContext()
.getSourceToSelectionExpressionMap()
.get(source))
.setFilter(addSourceFilters(executionContext, source))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add id node filter if say ids lenght is less than 10K or something?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant