feat: fixing comments

hypertrace · Nov 9, 2023 · b2d03da · b2d03da
1 parent 5497c5d
commit b2d03da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/...vability/src/shared/dashboard/data/graphql/explore/explore-cartesian-data-source.model.ts b/...vability/src/shared/dashboard/data/graphql/explore/explore-cartesian-data-source.model.ts
@@ -178,7 +178,7 @@ export abstract class ExploreCartesianDataSourceModel extends GraphQlDataSourceM
     const metricAggregationData = result.getMetricAggregationSeriesData(spec.name, spec.aggregation);
 
     return {
-      data: metricAggregationData?.value ? [['', metricAggregationData.value]] : [],
+      data: metricAggregationData.value ? [['', metricAggregationData.value]] : [],
       spec: spec
     };
   }

diff --git a/projects/observability/src/shared/dashboard/data/graphql/explore/explore-result.ts b/projects/observability/src/shared/dashboard/data/graphql/explore/explore-result.ts
@@ -82,11 +82,7 @@ export class ExploreResult {
   ): MetricAggregationData {
     return {
       key: spec.name,
-      ...(result
-        ? {
-            value: result?.[spec.resultAlias()].value as number
-          }
-        : {})
+      value: result?.[spec.resultAlias()].value as number
     };
   }
 
@@ -168,5 +164,5 @@ interface GroupData {
 
 interface MetricAggregationData {
   key: string;
-  value?: number;
+  value: number | undefined;
 }