fix: export method from time range service #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #2485 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 925 925
Lines 20610 20610
Branches 3254 3254
=======================================
Hits 17119 17119
Misses 3372 3372
Partials 119 119
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adisreyaj
previously approved these changes
Oct 24, 2023
This comment has been minimized.
This comment has been minimized.
| @@ -339,5 +339,6 @@ export const enum ExplorerQueryParam { | |||
| GroupLimit = 'limit', | |||
| Series = 'series', | |||
| Order = 'order', | |||
| Filters = 'filter' | |||
| Filters = 'filter', | |||
| Time = 'time' | |||
There was a problem hiding this comment.
I'm not sure I'd call this an explorer param. Consider treating time separately and always going through TR service.
There was a problem hiding this comment.
Makes sense, reverted
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exported
timeRangeFromUrlStringmethodalso added a query param to Explorer
time