Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing Filters from span details in waterfall widget #2502

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Nov 6, 2023

Description

Setting variable to remove filters from Span Details in multiple components (specifically Waterfall Widget) and fixing filter's styles.

Testing

Locally tested

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner November 6, 2023 18:35

This comment has been minimized.

@anandtiwary
Copy link
Contributor

As discussed, please share a screenshot with these filter icons always visible. Let's share it with Sudeep and see if he likes it.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2502 (be2066f) into main (418e1ef) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2502      +/-   ##
==========================================
- Coverage   83.04%   83.04%   -0.01%     
==========================================
  Files         925      925              
  Lines       20616    20620       +4     
  Branches     3257     3257              
==========================================
+ Hits        17120    17123       +3     
- Misses       3376     3377       +1     
  Partials      120      120              
Files Coverage Δ
...call/headers/span-detail-call-headers.component.ts 84.61% <100.00%> (-3.39%) ⬇️
...an-detail/request/span-request-detail.component.ts 100.00% <ø> (ø)
...-detail/response/span-response-detail.component.ts 100.00% <ø> (ø)
...ed/components/span-detail/span-detail.component.ts 90.38% <100.00%> (+0.18%) ⬆️
...nts/span-detail/tags/span-tags-detail.component.ts 84.00% <100.00%> (+0.66%) ⬆️
...s/waterfall/waterfall-widget-renderer.component.ts 53.84% <ø> (ø)
...hboard/widgets/waterfall/waterfall-widget.model.ts 66.66% <100.00%> (+4.16%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

This comment has been minimized.

This comment has been minimized.

@palbizu palbizu merged commit 1dc53b9 into main Nov 8, 2023
@palbizu palbizu deleted the RemovingFiltersFromSpanDetailsInWaterfallWidget branch November 8, 2023 17:45
Copy link

github-actions bot commented Nov 8, 2023

Unit Test Results

       4 files  ±0     316 suites  ±0   47m 48s ⏱️ - 3m 0s
1 131 tests ±0  1 131 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 141 runs  ±0  1 141 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1dc53b9. ± Comparison against base commit 418e1ef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants