Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): disable not working when working with formcontrol #2507

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

adisreyaj
Copy link
Contributor

  • Refactored to not mutate inputs.
  • Disable change was not getting reflected when using form controls, hence added manual change detection.

@adisreyaj adisreyaj self-assigned this Nov 10, 2023
@adisreyaj adisreyaj marked this pull request as ready for review November 10, 2023 06:33
@adisreyaj adisreyaj requested a review from a team as a code owner November 10, 2023 06:33
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1700605) 82.99% compared to head (81e38b2) 72.60%.
Report is 1 commits behind head on main.

Files Patch % Lines
projects/components/src/input/input.component.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2507       +/-   ##
===========================================
- Coverage   82.99%   72.60%   -10.40%     
===========================================
  Files         925      925               
  Lines       20636    20639        +3     
  Branches     3260     3260               
===========================================
- Hits        17127    14985     -2142     
- Misses       3389     5427     +2038     
- Partials      120      227      +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Unit Test Results

       4 files  ±0     316 suites  ±0   44m 43s ⏱️ + 1m 49s
1 131 tests ±0  1 131 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 141 runs  ±0  1 141 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3479f4d. ± Comparison against base commit 2fcae01.

@adisreyaj adisreyaj enabled auto-merge (squash) November 15, 2023 14:39
@adisreyaj adisreyaj merged commit badfc16 into main Nov 15, 2023
9 checks passed
@adisreyaj adisreyaj deleted the feat/input-disable branch November 15, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants