Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade hyperdash dependencies #2576

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

jake-bassett
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@jake-bassett jake-bassett requested a review from a team as a code owner December 13, 2023 18:46
Copy link

github-actions bot commented Dec 13, 2023

Test Results

       4 files  ±0     316 suites  ±0   33m 1s ⏱️ +2s
1 135 tests ±0  1 135 ✔️ ±0  0 💤 ±0  0 ±0 
1 145 runs  ±0  1 145 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit dec702e. ± Comparison against base commit 44f1d65.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44f1d65) 81.69% compared to head (dec702e) 81.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2576   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files         928      928           
  Lines       20787    20787           
  Branches     3135     3135           
=======================================
  Hits        16981    16981           
  Misses       3665     3665           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -34,8 +34,8 @@
"@angular/router": "^16.1.8",
"@apollo/client": "^3.8.5",
"@fullstory/browser": "^1.7.1",
"@hypertrace/hyperdash": "^1.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no lock change? were these already upgraded just not in the package.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed saving the file before commiting. Fixed.

@jake-bassett jake-bassett merged commit 557feff into main Dec 13, 2023
13 checks passed
@jake-bassett jake-bassett deleted the update-hyperdash-deps branch December 13, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants