feat(filter): expose a method #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunlalb
approved these changes
Jan 3, 2024
| this.navigationService.addQueryParametersToUrl(this.getQueryParamsObjectForFilters(filters)); | ||
| } | ||
|
|
||
| public getQueryParamsObjectForFilters(filters: Filter[]): QueryParamObject { |
There was a problem hiding this comment.
Suggested change
| public getQueryParamsObjectForFilters(filters: Filter[]): QueryParamObject { | |
| public buildQueryParamsForFilters(filters: Filter[]): QueryParamObject { |
nit: shorter name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
=======================================
Coverage 81.70% 81.71%
=======================================
Files 928 928
Lines 20792 20794 +2
Branches 3137 3137
=======================================
+ Hits 16989 16991 +2
Misses 3662 3662
Partials 141 141 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose a util method from
FilterUrlService.