fix: add clickOnRowToSelect option to table
#2604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
=======================================
Coverage 81.74% 81.74%
=======================================
Files 929 929
Lines 20845 20856 +11
Branches 3145 3153 +8
=======================================
+ Hits 17039 17049 +10
Misses 3665 3665
- Partials 141 142 +1 ☔ View full report in Codecov by Sentry. |
| @@ -342,6 +342,9 @@ export class TableComponent | |||
| @Input() | |||
| public selectionMode?: TableSelectionMode = TableSelectionMode.Single; | |||
|
|
|||
| @Input() | |||
| public clickOnRowToSelect?: boolean = true; | |||
There was a problem hiding this comment.
We have TableSelectionMode.None but we're not using that anywhere in the table component.
can we use that instead of creating a new component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With various usecases of table, it is not always required to select a row when its clicked on. There are usecases that just needs some action to be done on a row click instead of toggling its selection status.
To enable this, this PR introduces a boolean control in the table component.
Testing
Tested manually.
Checklist: