chore: remove kafka-zookeeper image (#52)

hypertrace · Oct 1, 2024 · 479c75f · 479c75f
1 parent f52ed31
commit 479c75f
Show file tree

Hide file tree

Showing 10 changed files with 2 additions and 272 deletions.
diff --git a/.github/workflows/docker-tests.yml b/.github/workflows/docker-tests.yml
diff --git a/.github/workflows/kafka-zookeeper/docker-compose.yml b/.github/workflows/kafka-zookeeper/docker-compose.yml
diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Build with Gradle
         uses: hypertrace/github-actions/gradle@main
         with:
-          args: build dockerBuildImages
+          args: dockerBuildImages
 
       - name: Run Trivy vulnerability scanner for kafka image
         uses: hypertrace/github-actions/trivy-image-scan@main
@@ -31,13 +31,6 @@ jobs:
           output-mode: github
           category: kafka
 
-      - name: Run Trivy vulnerability scanner for kafka-zookeeper image
-        uses: hypertrace/github-actions/trivy-image-scan@main
-        with:
-          image: hypertrace/kafka-zookeeper
-          output-mode: github
-          category: kafka-zookeeper
-
   validate-helm-charts:
     runs-on: ubuntu-20.04
     steps:

diff --git a/README.md b/README.md
@@ -22,25 +22,13 @@ To build kafka image locally, run:
 ```
 
 `Note:` 
-- docker-compose uses `kafka-zookeeper` image so you have to build it from that folder in case you are working on that one. 
 - To read more about installing and configuring helm chart refer [BUILD.md](/BUILD.md).
 
 ## Testing
 
-You can test the image you built after modification by running docker-compose or helm setup. 
-
-### docker-compose
-Change the tag for `kafka-zookeeper` from `:main` to `:test` in [docker-compose file](https://github.com/hypertrace/hypertrace/blob/main/docker/docker-compose.yml) like this.
-
-```yaml
-  kafka-zookeeper:
-    image: hypertrace/kafka-zookeeper:test
-    container_name: kafka-zookeeper
-    ...
-```
+You can test the image you built after modification by running docker-compose or helm setup.
 
 and then run `docker-compose up` to test the setup.
 
 ## Docker Image Source:
 - [DockerHub > kafka](https://hub.docker.com/r/hypertrace/kafka)
-- [DockerHub > kafka-zookeeper](https://hub.docker.com/r/hypertrace/kafka-zookeeper)
diff --git a/kafka-zookeeper/Dockerfile b/kafka-zookeeper/Dockerfile
diff --git a/kafka-zookeeper/build.gradle.kts b/kafka-zookeeper/build.gradle.kts
diff --git a/kafka-zookeeper/docker-bin/docker-healthcheck b/kafka-zookeeper/docker-bin/docker-healthcheck
diff --git a/kafka-zookeeper/docker-bin/start-kafka-zookeeper b/kafka-zookeeper/docker-bin/start-kafka-zookeeper
diff --git a/kafka-zookeeper/install.sh b/kafka-zookeeper/install.sh
diff --git a/settings.gradle.kts b/settings.gradle.kts
@@ -10,5 +10,4 @@ plugins {
   id("org.hypertrace.version-settings") version "0.2.0"
 }
 
-include(":kafka-zookeeper")
 include(":docker")