Skip to content

Commit

Permalink
[exporter/logging] Remove logging exporter (open-telemetry#11037)
Browse files Browse the repository at this point in the history
#### Description

It is September, which means we get to remove this deprecated component.

- The helm chart was updated to exclude the logging exporter already:
https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/UPGRADING.md#0840-to-0850.
- The Operator references have been updated:
open-telemetry/opentelemetry-operator#3259.
- Opentelemetry.io site final references to update:
open-telemetry/opentelemetry.io#5143

<!-- Issue number if applicable -->
#### Link to tracking issue
Related to
open-telemetry#7769
  • Loading branch information
TylerHelmuth authored Oct 3, 2024
1 parent 4ace638 commit f9d44de
Show file tree
Hide file tree
Showing 33 changed files with 45 additions and 897 deletions.
25 changes: 25 additions & 0 deletions .chloggen/remove-logging-exporter.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: loggingexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Removed the deprecated logging exporter. Use the debug exporter instead.

# One or more tracking issues or pull requests related to the change
issues: [11037]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
2 changes: 0 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ check-contrib:
-replace go.opentelemetry.io/collector/exporter=$(CURDIR)/exporter \
-replace go.opentelemetry.io/collector/exporter/debugexporter=$(CURDIR)/exporter/debugexporter \
-replace go.opentelemetry.io/collector/exporter/exporterprofiles=$(CURDIR)/exporter/exporterprofiles \
-replace go.opentelemetry.io/collector/exporter/loggingexporter=$(CURDIR)/exporter/loggingexporter \
-replace go.opentelemetry.io/collector/exporter/nopexporter=$(CURDIR)/exporter/nopexporter \
-replace go.opentelemetry.io/collector/exporter/otlpexporter=$(CURDIR)/exporter/otlpexporter \
-replace go.opentelemetry.io/collector/exporter/otlphttpexporter=$(CURDIR)/exporter/otlphttpexporter \
Expand Down Expand Up @@ -363,7 +362,6 @@ restore-contrib:
-dropreplace go.opentelemetry.io/collector/consumer/consumertest \
-dropreplace go.opentelemetry.io/collector/exporter \
-dropreplace go.opentelemetry.io/collector/exporter/debugexporter \
-dropreplace go.opentelemetry.io/collector/exporter/loggingexporter \
-dropreplace go.opentelemetry.io/collector/exporter/nopexporter \
-dropreplace go.opentelemetry.io/collector/exporter/otlpexporter \
-dropreplace go.opentelemetry.io/collector/exporter/otlphttpexporter \
Expand Down
1 change: 0 additions & 1 deletion cmd/builder/internal/config/default.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ receivers:
- gomod: go.opentelemetry.io/collector/receiver/otlpreceiver v0.110.0
exporters:
- gomod: go.opentelemetry.io/collector/exporter/debugexporter v0.110.0
- gomod: go.opentelemetry.io/collector/exporter/loggingexporter v0.110.0
- gomod: go.opentelemetry.io/collector/exporter/nopexporter v0.110.0
- gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.110.0
- gomod: go.opentelemetry.io/collector/exporter/otlphttpexporter v0.110.0
Expand Down
1 change: 0 additions & 1 deletion cmd/builder/test/core.builder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ replaces:
- go.opentelemetry.io/collector/connector/connectorprofiles => ${WORKSPACE_DIR}/connector/connectorprofiles
- go.opentelemetry.io/collector/exporter => ${WORKSPACE_DIR}/exporter
- go.opentelemetry.io/collector/exporter/debugexporter => ${WORKSPACE_DIR}/exporter/debugexporter
- go.opentelemetry.io/collector/exporter/loggingexporter => ${WORKSPACE_DIR}/exporter/loggingexporter
- go.opentelemetry.io/collector/exporter/exporterprofiles => ${WORKSPACE_DIR}/exporter/exporterprofiles
- go.opentelemetry.io/collector/extension => ${WORKSPACE_DIR}/extension
- go.opentelemetry.io/collector/extension/auth => ${WORKSPACE_DIR}/extension/auth
Expand Down
2 changes: 0 additions & 2 deletions cmd/otelcorecol/builder-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ receivers:
- gomod: go.opentelemetry.io/collector/receiver/otlpreceiver v0.110.0
exporters:
- gomod: go.opentelemetry.io/collector/exporter/debugexporter v0.110.0
- gomod: go.opentelemetry.io/collector/exporter/loggingexporter v0.110.0
- gomod: go.opentelemetry.io/collector/exporter/nopexporter v0.110.0
- gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.110.0
- gomod: go.opentelemetry.io/collector/exporter/otlphttpexporter v0.110.0
Expand Down Expand Up @@ -72,7 +71,6 @@ replaces:
- go.opentelemetry.io/collector/exporter => ../../exporter
- go.opentelemetry.io/collector/exporter/debugexporter => ../../exporter/debugexporter
- go.opentelemetry.io/collector/exporter/exporterprofiles => ../../exporter/exporterprofiles
- go.opentelemetry.io/collector/exporter/loggingexporter => ../../exporter/loggingexporter
- go.opentelemetry.io/collector/exporter/nopexporter => ../../exporter/nopexporter
- go.opentelemetry.io/collector/exporter/otlpexporter => ../../exporter/otlpexporter
- go.opentelemetry.io/collector/exporter/otlphttpexporter => ../../exporter/otlphttpexporter
Expand Down
3 changes: 0 additions & 3 deletions cmd/otelcorecol/components.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions cmd/otelcorecol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ require (
go.opentelemetry.io/collector/connector/forwardconnector v0.110.0
go.opentelemetry.io/collector/exporter v0.110.0
go.opentelemetry.io/collector/exporter/debugexporter v0.110.0
go.opentelemetry.io/collector/exporter/loggingexporter v0.110.0
go.opentelemetry.io/collector/exporter/nopexporter v0.110.0
go.opentelemetry.io/collector/exporter/otlpexporter v0.110.0
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.110.0
Expand Down Expand Up @@ -214,8 +213,6 @@ replace go.opentelemetry.io/collector/exporter/debugexporter => ../../exporter/d

replace go.opentelemetry.io/collector/exporter/exporterprofiles => ../../exporter/exporterprofiles

replace go.opentelemetry.io/collector/exporter/loggingexporter => ../../exporter/loggingexporter

replace go.opentelemetry.io/collector/exporter/nopexporter => ../../exporter/nopexporter

replace go.opentelemetry.io/collector/exporter/otlpexporter => ../../exporter/otlpexporter
Expand Down
1 change: 0 additions & 1 deletion component/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ func TestNewType(t *testing.T) {
{name: "kinetica"},
{name: "kubeletstats"},
{name: "loadbalancing"},
{name: "logging"},
{name: "logicmonitor"},
{name: "logstransform"},
{name: "logzio"},
Expand Down
2 changes: 1 addition & 1 deletion connector/forwardconnector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ service:
# - forward
# traces/log:
# receivers: [forward]
# exporters: [logging]
# exporters: [debug]
```

[Connectors README]:../README.md
2 changes: 1 addition & 1 deletion exporter/debugexporter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ See also the [Troubleshooting][troubleshooting_docs] document for examples on us

The following settings are optional:

- `verbosity` (default = `basic`): the verbosity of the logging export
- `verbosity` (default = `basic`): the verbosity of the debug exporter
(detailed|normal|basic). When set to `detailed`, pipeline data is verbosely
logged.
- `sampling_initial` (default = `2`): number of messages initially logged each
Expand Down
4 changes: 2 additions & 2 deletions exporter/debugexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ var (
}
)

// Config defines configuration for logging exporter.
// Config defines configuration for debug exporter.
type Config struct {
// Verbosity defines the logging exporter verbosity.
// Verbosity defines the debug exporter verbosity.
Verbosity configtelemetry.Level `mapstructure:"verbosity,omitempty"`

// SamplingInitial defines how many samples are initially logged during each second.
Expand Down
4 changes: 0 additions & 4 deletions exporter/debugexporter/exporter.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// NOTE: If you are making changes to this file, consider whether you want to make similar changes
// to the Logging exporter in /exporter/internal/common/logging_exporter.go, which has similar logic.
// This is especially important for security issues.

package debugexporter // import "go.opentelemetry.io/collector/exporter/debugexporter"

import (
Expand Down
1 change: 0 additions & 1 deletion exporter/loggingexporter/Makefile

This file was deleted.

52 changes: 0 additions & 52 deletions exporter/loggingexporter/README.md

This file was deleted.

94 changes: 0 additions & 94 deletions exporter/loggingexporter/config.go

This file was deleted.

Loading

0 comments on commit f9d44de

Please sign in to comment.