refactor: use GitHub native popover to substitue ours #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyn1998
commented
Apr 24, 2024
tyn1998
force-pushed
the
refactor/native-popover
branch
from
a6774de to
5ef1845
Compare
tyn1998
force-pushed
the
refactor/native-popover
branch
from
5ef1845 to
22c91ff
Compare
2024-04-24.23.05.15.movHello @lhbvvvvv, I have implemented a component called |
tyn1998
commented
Apr 29, 2024
tyn1998
commented
Apr 29, 2024
There was a problem hiding this comment.
LGTM and guys welcome to your local test and screenshots @wxharry @lhbvvvvv @andyhuang18 @wangyantong2000 🚀
tyn1998
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
NativePopover.mov-8mb.mp4
Checklist
Others