Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weekStartsOn propagation #523

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

weekStartsOn propagation #523

wants to merge 34 commits into from

Conversation

gbili
Copy link

@gbili gbili commented Oct 7, 2021

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Describe your pr here.

Pass the weekStartsOn prop to DefinedRange. Fixes the inconsistency between the Calendar and the DefinedRange.
Also changed the order of StaticRanges to make them appear chronologically. Last Month, Last Week, Yesterday, Today, This Week, This Month. If this poses a problem I can fix it, but I needed that order, so I made it the default (my bad not to separate commits).

Related Issue: #xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants