Add fcploadplugin #14
Conversation
|
|
|
||
| try: | ||
| plugin_uri | ||
| except NameError: |
There was a problem hiding this comment.
This seems a very strange way to check for validity. Do these bindings really not have some kind of key class that will parse them?
There was a problem hiding this comment.
It is done in the same way at https://github.com/freenet/pyFreenet/blob/master/fcp/upload.py#L203
There was a problem hiding this comment.
Okay. These utilities could use some cleanup then - I don't see a good reason to parse like that. In addition, such common things should be implemented in the library instead of the included utilities to avoid such a large pressure toward duplicating code. I'm surprised there isn't a FreenetKey class in the library already.
Is there a reason to parse this? My understanding is that the leading "freenet:" is unnecessary. There are no decisions made from parsing at this level other than to error out when it's invalid. Would it work to send it to the node without checking it and let the node return any errors?
|
Thanks for posting this! |
|
Any word on responding to the feedback? |
|
Closed for inactivity. Please let me know if you'd like it to be reopened. |
Added a new command-line freenet application that loads a plugin to the node, given a plugin URI. Internally it is using the LoadPlugin (https://wiki.freenetproject.org/FCPv2/LoadPlugin) message.