Fix formatting findings sitemgr #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix some probless found by this change
and some more methods to fulfil the type annotation. This created two new warnings for the case where the code assumes that rec['name'] is bytes and not str. I didn't address those since I want this to be a low-risk change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done here is to enable the static code checks (flake8 and mypy) that are now available, and started addressing the simple weaknesses found.
There are still some more complex weaknesses such as Cyclomatic complexity too high, that I have not addressed and the adding of type hints, I have so far only done in the trivial cases. In any case, I consider this an improvement and I may continue the work (in this module or in other modules) at some other time.