Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files in manifest #5

Merged
merged 84 commits into from
Jan 6, 2015
Merged

Files in manifest #5

merged 84 commits into from
Jan 6, 2015

Conversation

ArneBab
Copy link
Contributor

@ArneBab ArneBab commented Aug 7, 2014

This changes freesite inserts to put the smallest files into a container, up to 2 MiB.

It starts with the smallest files referenced from index.html and includes all files which fit in 2 MiB. Then it checks whether further unreferenced files fit into 2 MiB. Then it adds all further files, starting with the slowest, until there are at most 500 files left out of the container. The rest of the files are uploaded as separate files as before (CHKs).

For graphic-heavy freesites like Freenet_Meltdown, this can reduce the site load time by more than factor 3.

drak@kaverne added 30 commits July 29, 2014 08:20
--HG--
extra : amend_source : f4246cc852f247e0210e4cb1050cae77cb1e51cb
…st and then does not show up in the queue as separate upload.
…instead of the stored datalength which might no longer be up to date when the file changed during the runtime of freesitemgr.
@ArneBab
Copy link
Contributor Author

ArneBab commented Sep 9, 2014

the current last comment hopefully fixes a regression I did not realize was there: freesitemgr never marked a site as done.

@ArneBab
Copy link
Contributor Author

ArneBab commented Sep 10, 2014

there’s still a bug which leads to freesitemgr seeing some sites as changed which did not change.

@ArneBab ArneBab changed the title Files in manifest - to be merged *after* pull-request 4 Files in manifest Sep 23, 2014
@ArneBab
Copy link
Contributor Author

ArneBab commented Sep 23, 2014

Commit ef5325e finally fixes the mistaken reupload. With this, I consider this ready for merging. There are still bugs, but not more than before adding files to the manifest.

And the changes are no longer a privacy risk (uploading many sites at the same time even though they did not change would allow timing attacks to correlate IDs).

@Thynix
Copy link
Contributor

Thynix commented Dec 20, 2014

It looks like this library assumes Python 2 in the way it imports things, and so currently fails to run if Python 3 is the default Python. (As it is on Arch.) That's a separate problem though.

@ArneBab
Copy link
Contributor Author

ArneBab commented Dec 21, 2014

ah, yes - for starters I think I should just use python2 as binary. I consider porting to python3 as important, but not blocking (it’s no breakage, but rather not adding a new feature).

@Thynix Thynix merged commit 03de064 into hyphanet:master Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants