Skip to content

Commit

Permalink
Fix jinja2 import after version upgrade
Browse files Browse the repository at this point in the history
  • Loading branch information
marcospri committed Jan 25, 2024
1 parent 8c1f5e9 commit a00811c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bouncer/util.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from urllib import parse

import jinja2
from markupsafe import Markup
from pyramid import i18n

_ = i18n.TranslationStringFactory(__package__)
Expand Down Expand Up @@ -148,8 +148,8 @@ def get_pretty_url(url):
return None

pretty_url = parsed_url.netloc[:NETLOC_MAX_LENGTH]
if len(parsed_url.netloc) > NETLOC_MAX_LENGTH: # pragma: nocover
pretty_url += jinja2.Markup("…")
if len(parsed_url.netloc) > NETLOC_MAX_LENGTH:
pretty_url += Markup("…")
return pretty_url


Expand Down
6 changes: 6 additions & 0 deletions tests/unit/bouncer/util_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ def test_parse_document_returns_authority(es_annotation_doc):
assert authority == "hypothes.is"


def test_get_pretty_url_for_long_url():
long_netloc = "https://www.verylongdomainthatkeepsgoingandgoing.com"

assert "www.verylongdomainthatkeepsgoi…" == util.get_pretty_url(long_netloc)


@pytest.fixture
def es_annotation_doc():
"""
Expand Down

0 comments on commit a00811c

Please sign in to comment.