Enable many more Ruff linter rules #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
commented
Jan 28, 2025
| @@ -153,10 +113,20 @@ ignore = [ | |||
| "PLR0913", # Too many arguments. Tests often have lots of arguments. | |||
| "PLR0917", # Too many positional arguments. Tests often have lots of arguments. | |||
| "PLR0904", # Too many public methods. Test classes often have lots of test methods. | |||
| "S101", # Use of `assert` detected. | |||
There was a problem hiding this comment.
We want to allow assert's in tests, obviously.
seanh
commented
Jan 28, 2025
Comment on lines
+124
to
+129
| "{{ cookiecutter.package_name }}/migrations/*" = [ | ||
| "INP001", | ||
| ] | ||
| "bin/*" = [ | ||
| "INP001", | ||
| ] |
There was a problem hiding this comment.
Missing __init__.py files, which apparently can cause tools like coverage and pytest to silently skip these directories: https://pypi.org/project/flake8-no-pep420/. I don't think we want to add these to migrations/ and bin/?
seanh
force-pushed
the
enable-ruff-rules
branch
from
3ac3bb2 to
de3e999
Compare
marcospri
approved these changes
Jan 29, 2025
...and switch from an opt-in to an opt-out strategy where we enable ALL rules and then disable certain specific rules or sets of rules. This means that when new versions of Ruff come out new rules will be enabled by default. Slack discussion: https://hypothes-is.slack.com/archives/C1MA4E9B9/p1737635626518379
seanh
force-pushed
the
enable-ruff-rules
branch
from
de3e999 to
6afb0c6
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and switch from an opt-in to an opt-out strategy where we enable ALL
rules and then disable certain specific rules or sets of rules. This
means that when new versions of Ruff come out new rules will be enabled
by default.
Slack discussion: https://hypothes-is.slack.com/archives/C1MA4E9B9/p1737635626518379
Draft PRs to apply this to apps: