Allow ModalDialogs with variant='custom' #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
custom-modal-dialog
branch
from
f722bc3
to
4627b19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 60
Lines 934 934
Branches 351 351
=========================================
Hits 934 934 ☔ View full report in Codecov by Sentry. |
robertknight
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hypothesis/client#6151 and hypothesis/client#6158
Some time ago we added support for
variant="custom"inDialogs, which makes it render providedchildrenverbatim, instead of wrapped in aPanel.However, that capability was not added to
ModalDialog, so this PR brings that to make it consistent.It is also required so that we can use
ModalDialogfor the client's notebook, bringing some accessibility improvements in the process.