Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move email-sending code into EmailService #9329

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

mtomilov
Copy link
Contributor

@mtomilov mtomilov commented Feb 6, 2025

Refs #9285

Basically it's a refactoring of EmailService out of tasks/mailer

Testing

@mtomilov mtomilov force-pushed the move-email-sending-code-into-email-service branch from aec26c6 to f69cf07 Compare February 6, 2025 12:29
@mtomilov mtomilov requested a review from seanh February 6, 2025 12:31
Copy link
Contributor

@seanh seanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When deploying this make sure to test something that actually sends an email on staging and production (e.g. password reset)

h/services/email.py Outdated Show resolved Hide resolved
tests/unit/h/tasks/mailer_test.py Outdated Show resolved Hide resolved
@mtomilov mtomilov force-pushed the move-email-sending-code-into-email-service branch 2 times, most recently from 15c0394 to 78d9b29 Compare February 6, 2025 17:39
@mtomilov mtomilov force-pushed the move-email-sending-code-into-email-service branch from 78d9b29 to 8ce2943 Compare February 6, 2025 17:47
@mtomilov mtomilov merged commit bd9f7d7 into main Feb 7, 2025
11 checks passed
@mtomilov mtomilov deleted the move-email-sending-code-into-email-service branch February 7, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants