Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mention json payload #9331

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Update mention json payload #9331

merged 1 commit into from
Feb 10, 2025

Conversation

mtomilov
Copy link
Contributor

@mtomilov mtomilov commented Feb 7, 2025

Refs #9322, #9322

Basically just returning original_userid to make it easier for API consumers

@mtomilov mtomilov force-pushed the update-mention-json-payload branch from 28d8e5d to c614b6f Compare February 7, 2025 12:32
@mtomilov mtomilov requested review from marcospri and acelaya February 7, 2025 12:35
@mtomilov mtomilov force-pushed the update-mention-json-payload branch from c614b6f to f6ffbe8 Compare February 7, 2025 12:36
@marcospri
Copy link
Member

marcospri commented Feb 7, 2025

LGTM, This matches the proposal over: https://hypothes-is.slack.com/archives/C4K6M7P5E/p1738756919810279

@mtomilov mtomilov force-pushed the update-mention-json-payload branch from f6ffbe8 to 829655b Compare February 7, 2025 14:45
@mtomilov mtomilov force-pushed the update-mention-json-payload branch from 829655b to 5fa9481 Compare February 7, 2025 14:47
@mtomilov mtomilov requested a review from acelaya February 7, 2025 14:47
@mtomilov mtomilov merged commit e3b812b into main Feb 10, 2025
11 checks passed
@mtomilov mtomilov deleted the update-mention-json-payload branch February 10, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants