Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send tags header to mandrill #9332

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Send tags header to mandrill #9332

merged 1 commit into from
Feb 11, 2025

Conversation

mtomilov
Copy link
Contributor

@mtomilov mtomilov commented Feb 7, 2025

Refs #9286

Testing

Unfortunately you can't print the new header in test html since we add it only at a later stage in send so we need to rely on just unit tests here.

@mtomilov mtomilov force-pushed the send-tags-header-to-mandrill branch 2 times, most recently from 96225d3 to ca308b7 Compare February 7, 2025 16:21
@mtomilov mtomilov force-pushed the send-tags-header-to-mandrill branch from ca308b7 to d4cfdf3 Compare February 7, 2025 16:22
@mtomilov mtomilov requested a review from seanh February 10, 2025 11:34
Copy link
Contributor

@seanh seanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, I'm curious to see how the tags show up in the Mandrill dashboard once this is deployed

h/emails/flag_notification.py Show resolved Hide resolved
h/tasks/mailer.py Show resolved Hide resolved
@mtomilov mtomilov merged commit d0a015a into main Feb 11, 2025
11 checks passed
@mtomilov mtomilov deleted the send-tags-header-to-mandrill branch February 11, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants