Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xwayland: support HiDPI scale #6446

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

xwayland: support HiDPI scale #6446

wants to merge 1 commit into from
+59 −14

Conversation

moetayuko
Copy link

@moetayuko moetayuko commented Jun 12, 2024 •
edited
Loading

Describe your PR, what does it fix/add?

This supports the xorg-xwayland patch at https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/733

Ported from https://gitlab.freedesktop.org/lilydjwg/wlroots/-/commit/5a7c65cab11c9f3c3dc79f9c4cfb8a6acf6cbaae

See #6281 for motivation.

AUR package hyprland-hidpi-xprop-git applies this patch on top of hyprland mainline. After installing, do the following to enable (scaling factor 2 in this example):

  1. Add exec-once = systemctl --user start xsettingsd.service && echo "Xft.dpi: 192" | xrdb -merge && xprop -root -format _XWAYLAND_GLOBAL_OUTPUT_SCALE 32c -set _XWAYLAND_GLOBAL_OUTPUT_SCALE 2 to hyprland configuration.
  2. Add the following to ~/.config/xsettingsd/xsettingsd.conf 
    Gdk/UnscaledDPI 98304
Gdk/WindowScalingFactor 2
  3. Remove GDK_SCALE, QT_SCALE_FACTOR, and other per-application scaling options.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

N/A

Is it ready for merging, or does it need work?

No, for cherry-pick only

@vaxerski
Copy link
Member

what advantages does this have over force_zero_scaling?

@moetayuko
Copy link
Author

what advantages does this have over force_zero_scaling?

Quoting from my description in #6281:

The official Xwayland scaling solution xwayland:force_zero_scaling does not support multi-monitor with different scale factors. Specifically, when having two monitors of scale factors 2 and 1, Xwayland apps look good on the one of scale factor 2, but 2x larger on the one of scale factor 1.

@vaxerski vaxerski force-pushed the main branch 2 times, most recently from 1184395 to b16fb97 Compare July 24, 2024 16:53
@alexhulbert
Copy link

What is required to get this into a state where it can be merged? I would love to see this feature merged into Hyprland.

@notnynx notnynx mentioned this pull request Dec 27, 2024
Closed
@ParaN3xus
Copy link
Contributor

It's broken on latest Hyprland. XWayland appliacations squeezed to left top cornor of their window frame.

@moetayuko
Copy link
Author

It's broken on latest Hyprland. XWayland appliacations squeezed to left top cornor of their window frame.

I'm on vacation and don't have a hyprland device on hand to investigate the fix.

@moetayuko
Copy link
Author

It's broken on latest Hyprland. XWayland appliacations squeezed to left top cornor of their window frame.

I'm on vacation and don't have a hyprland device on hand to investigate the fix.

fixed

@ParaN3xus
Copy link
Contributor

Thank you for your work. I noticed that this PR has caused issue #5561 to reappear. Would you mind also taking a look at this issue?

@moetayuko
Copy link
Author

Thank you for your work. I noticed that this PR has caused issue #5561 to reappear. Would you mind also taking a look at this issue?

does this work for you?
patch.txt

@ParaN3xus
Copy link
Contributor

It works! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core protocols xwayland
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moetayuko @vaxerski @alexhulbert @ParaN3xus