protocols: add hyprland_lock_notify_v1 implementation #9092
+154
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
|
bump hyprland-protocols dep to 0.6.0 cuz ci fails |
|
Meson too. |
PaideiaDilemma
force-pushed
the
main
branch
3 times, most recently
from
ce00def to
d43438d
Compare
vaxerski
reviewed
Jan 17, 2025
|
If we would relock the session with I think that behavior is fine, since something already went wrong if a user needs to restore and the error makes sense in that context. We wouldn't want to receive a second locked notification (would be a protocol error) |
|
yes thats fine |
PaideiaDilemma
force-pushed
the
main
branch
3 times, most recently
from
5c08bc2 to
1fb430b
Compare
littleblack111
pushed a commit
to littleblack111/Hyprland
that referenced
this pull request
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires hyprwm/hyprland-protocols#12
Describe your PR, what does it fix/add?
Implements the proposed
hyprland-lock-notify-v1protocol.It is basically IdleNotify, but no timer stuff. Pretty straight forward.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Ready