refactor(xwayland): improve dnd and cleanup #9405
Conversation
|
some edge cases |
|
g2g |
|
christ, I'll have to test this myself a bit because in the dnd code when you touch something then some fucking app implodes |
should be good lmk how that goes |
|
did you find any bugs with this? @vaxerski or nah |
|
I should make a rule that every time you ping me I delay my review by 2 days |
|
dnd dolphin -> kitty = broken by this took me just 2 minutes |
|
atleast its better than before lol |
|
can you explain what u mean by broken lol |
|
nvm i see now |
|
broke more shit |
|
atleast kitty is fixed now |
|
kitty officially fixed |
|
|
idk what is up with chromium tbh |
|
probably not an issue here |
|
cuz i can perfectly drop into any other xwayland app |
cant drop into middle before ba57bc0 |
nnyyxxxx
force-pushed
the
patch-2
branch
3 times, most recently
from
cfeaf59 to
c2b9ecf
Compare
nnyyxxxx
changed the title
|
can you take another look, and see if anything else needs fixing other than chromium? |
|
yea, sec |
|
both issues look fixed for me, can't find any bugs from short testing |
nnyyxxxx
force-pushed
the
patch-2
branch
2 times, most recently
from
40f98b6 to
4b4072b
Compare
|
a |
|
im having a stroke |
|
review when |
|
when I have some time to test this thoroughly |
|
wouldnt you have to test thoroughly after i make changes according to your reviews as well? when you do review of course? whats the point of reviewing after you test? wouldnt it be better to review now so you dont have to test for a second time after i make changes according to your reviews? |
|
going based off of your message ofc |
|
I did skim through it and didnt find anything immediately wrong |
|
okay |
fixes #9154
fixes #8964
fixes #8994