Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subsurface): dont try to access popup surfaces when handling subsurface updates #9421

Merged
merged 2 commits into from
Feb 17, 2025
Merged

fix(subsurface): dont try to access popup surfaces when handling subsurface updates #9421

merged 2 commits into from
Feb 17, 2025

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Feb 16, 2025 •
edited
Loading

fixes #9419

@nnyyxxxx nnyyxxxx changed the title fix(subsurface): add additional checks to prevent possible crashes fix(subsurface): dont try to access popup surfaces when handling subsurface updates Feb 16, 2025
@vaxerski
Copy link
Member

patch.txt
doesnt this achieve the same with less loc changed and less useless props (inert)

@nnyyxxxx
Copy link
Contributor Author

mine prevents invalid popups from being processed, allat patch does is just add null checks

mine better

@nnyyxxxx
Copy link
Contributor Author

also my changes are at the source

@nnyyxxxx
Copy link
Contributor Author

less loc doesnt mean better lol

vaxerski
vaxerski previously approved these changes Feb 16, 2025
View reviewed changes
src/desktop/Subsurface.cpp Outdated Show resolved Hide resolved
src/desktop/Subsurface.cpp Outdated Show resolved Hide resolved
src/desktop/Popup.hpp Outdated Show resolved Hide resolved
@vaxerski
Copy link
Member

woops "approved" by accident

@nnyyxxxx nnyyxxxx requested a review from vaxerski February 16, 2025 21:18
vaxerski
vaxerski approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit d01f994 into hyprwm:main Feb 17, 2025
12 checks passed
@nnyyxxxx nnyyxxxx deleted the patch-1 branch February 18, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
core desktop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPopup errors forcing unexpected exit
2 participants
@nnyyxxxx @vaxerski