Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the GH action to the renamed
main
branch, adds a comparison of generated data and query parameters to the action, and fixes small compiler warnings encountered with gcc-13.Note on the change in
phash.c
jcch-dbgen/skew/phash.c
Lines 85 to 91 in 55da3ba
I generated some data and added a comparison to the GH action. Thus, I noticed that there were discrepancies between my machine (+ GH macOS runners) and the GH Ubuntu runners (+ nemea). I am not 100% sure if it's an STL or a CPU architecture thing.
The generated data is not 100% accurate compared to the current master branch BUT at least it is consistent now. For the
customer
/supplier
tuples in the skewed dataset, we introduce a systematic bias in thenationkey
assignment, but it is not clear if that error also favors a higher bin here:jcch-dbgen/skew/phash.c
Lines 62 to 67 in a7cfdd2
However, as it is a consistant bias affecting all tuples/
nationkey
s the same, it should not make a difference in the end.An alternative to avoid the systematic error would be to use
lround()
. The results are also consistent across the systems. The differences for both compared to the master are the same: 5 tuples for SF 0.01, 8 tuples for SFs 1 and 10.