Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo item type fqdn if namespace equals #67

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theuargb
Copy link

@theuargb theuargb commented Jun 1, 2022

Once SearchResultsInterface and ItemInterface share the same namespace, reflection returns $resultItemsType relative to $resultType, while the module requires FQDN

Current behavior:

$resultType = Vendor\Module\Api\Data\SearchResultsInterface
$resultItemsType = ItemInterface[]

Fixed behavior:

$resultType = Vendor\Module\Api\Data\SearchResultsInterface
$resultItemsType = Vendor\Module\Api\Data\ItemInterface[]

@theuargb theuargb marked this pull request as draft June 2, 2022 11:30
@Vinai
Copy link
Collaborator

Vinai commented Jun 13, 2022

@theuargb Thank you for the PR!
Can you please let me know what is missing in order to move it out of draft status?

Ideally I would also like to add a test to replicate the issue.

@theuargb
Copy link
Author

theuargb commented Jun 13, 2022

Hi. Everything is fine for me, while I’m using modified version this days, so it could be merged safely (imho). I just wanted to ensure if implemented approach is fine)

@Vinai
Copy link
Collaborator

Vinai commented Dec 9, 2022

@theuargb I would like to pick this PR up again - would you say it's ready?

@theuargb
Copy link
Author

theuargb commented Dec 9, 2022

@Vinai
hi. It’s great to hear). I thought about this one a couple of times in the past month but I still had no luck writing back.
Yes, I think it’s ready, while the used approach could be a topic to discuss.

Nevertheless mentioned bug is still present. I used to use a collection connector as a workaround(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants