Python Packaging #1753
Open
Python Packaging #1753
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Marc's suggestion, making a PR here for review.
I put together packaging information for Python so that rpi-rgb-led-matrix can be installed as a package directly with pip. This is currently in a "works for me" state.
The build-rpi-rgb-led-matrix.py script uses the Hatch prebuild hooks to call the makefile and build the C libraries. The settings in hatch.toml make the Python package out of the files in "bindings/python/rgbmatrix". This does not include extensive checking for failures of the make process or passing of build options for different python packagers or cross-compiling.
Also note that PyPi no longer accepts local tags for version numbers. I had intended to put in code that would calculate a version based on the previous commit to the repo (ie: '0.0.1+20240924' for commit 0ff6a69). That may still be a viable strategy if you don't care about publishing to PyPi.