Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: address failing tests #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ajbozarth
Copy link
Member

@ajbozarth ajbozarth commented Feb 25, 2025

Description

While working on #397 I was updating some tests and when I ran pytest some tests were failing. I found that our CI only runs pytest -m unit which is a small subset of our total tests. I opened #400 to handle adding the correct decorators to all our tests, but addressed the failing tests here.

Changes:

  • fixed errors_test.py which were failing since feat: retryable implementation #363 was merged
  • renamed workflows/multi_agents.py to workflows/test_multi_agents.py since pytest only looks for files named test_*.py or *_test.py, once run these tests were failing due to an invalid ollama model.
  • I updated the default ollama model to be llama3.1 instead of llama3.1:8b. I have llama3.1:latest installed locally and not llama3.1:8b so this e2e test was erroring. By updating the default to remove the tag it addresses the issue and matches will all other use cases in the current code.

Checklist

Signed-off-by: Alex Bozarth <[email protected]>
@ajbozarth ajbozarth added bug Something isn't working test python Python related functionality labels Feb 25, 2025
@ajbozarth ajbozarth self-assigned this Feb 25, 2025
@ajbozarth ajbozarth requested a review from a team as a code owner February 25, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Python related functionality test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant