-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue 235 by completing CLI deploy command #257
base: main
Are you sure you want to change the base?
Conversation
* --dry-run option for OR * fix issue when deploying now without a deployments directory
|
||
try: | ||
if self.docker(): | ||
deploy = Deploy(agents_yaml, workflow_yaml, bee_api_key, bee_api, self.url()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding "DRY_RUN=1" here enables the dry run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Deploy constructor is expecting like this:
deploy = Deploy("../tests/examples/condition_agents.yaml", "../tests/examples/condition_workflow.yaml", "BEE_API_KEY=sk-proj-testkey BEE_API=http://192.168.86.45:4000")
The format of the environment variables is like "key1=value1 key2=value2"
There is an issue that the |
#254 fixes the working directory issue. |
Thank you @akihikokuroda. I will rebase and resubmit this PR. |
@akihikokuroda getting a series of issues ... maybe you can take a look
I am passing You can check this by doing the following: gh pr checkout 257
...
pytest Including output here: issue235_pytest_output.txt |
Made some changes @akihikokuroda and got further but still failing. FYI The issue of |
@maximilien Yes, I want to move the temp directory somewhere else. I'll look into why the directory returned by I put fix in #264 |
OK will try this again now that #264 is merged. Likely in a few hours |
fixes issue 235 but does not work. Needed:
--dry-run
option forDeploy
OR
@akihikokuroda let's do the easiest thing to get this working then we can iterate and improve
This is the output when I run: test-fail-output.txt