Fix no or multiple commas between sections

i-ky · May 28, 2024 · 9ee404b · 9ee404b
1 parent 9dae343
commit 9ee404b
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/src/basset.cpp b/src/basset.cpp
@@ -167,17 +167,11 @@ class CompilationDatabase : ofstream {
 template <typename... Args>
 CompilationDatabase::CompilationDatabase(Args &&... args)
     : ofstream(std::forward<Args>(args)...) {
-  *this << "[";
+  *this << '[';
 }
 
 void CompilationDatabase::add(const string &directory,
                               const vector<string> &command) {
-  if (first) {
-    first = false;
-  } else {
-    *this << ',';
-  }
-
   vector<string> files;
 
   for (auto &&argument : command) {
@@ -187,18 +181,24 @@ void CompilationDatabase::add(const string &directory,
   }
 
   for (const auto &file : files) {
+    if (first) {
+      first = false;
+    } else {
+      *this << ',';
+    }
+
     *this << "\n"
              "  {\n"
              // clang-format off
              "    \"directory\": \"" << directory << "\",\n"
              // clang-format on
              "    \"arguments\": [";
 
-    bool first{true};
+    bool first_arg{true};
 
     for (const auto &arg : command) {
-      if (first) {
-        first = false;
+      if (first_arg) {
+        first_arg = false;
       } else {
         *this << ',';
       }