Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a isObject helper function #1766

Merged
merged 1 commit into from
Jul 15, 2024
Merged

create a isObject helper function #1766

merged 1 commit into from
Jul 15, 2024

Conversation

VIKTORVAV99
Copy link
Contributor

Creates a isObject helper function to reduce code duplication.

Also includes the relevant tests.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 97.206% (+0.06%) from 97.143%
when pulling abe3851 on VIKTORVAV99:isObject_helper
into 92bc147 on i18next:master.

@adrai adrai merged commit 294e14b into i18next:master Jul 15, 2024
8 of 9 checks passed
@VIKTORVAV99
Copy link
Contributor Author

@adrai I think that is it for non breaking changes. If you want to make a minor release.

Then I'll create some PRs with breaking changes tomorrow.

@adrai
Copy link
Member

adrai commented Jul 15, 2024

v14.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VIKTORVAV99 @coveralls @adrai