feat: adding global middleware support to Server #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `globalMiddlewares` field to `Server` struct to allow middleware execution for all routes. - Introduced `Use` method to register global middlewares. - Refactored `Listen` method by extracting route registration logic into `registerRoutes` to handle both global and route-specific middlewares. - Simplified middleware chaining through the new `registerMiddlewares` helper function.
- Added `TestUse` to verify that global middlewares are correctly executed for all routes.
- Test ensures that middleware logs request method and path, and sets custom response header.
- Verifies middleware interaction with route-specific handler for `/login/{name}`.
i9si
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalMiddlewaresfield toServerstruct to allow middleware execution for all routes.Usemethod to register global middlewares.Listenmethod by extracting route registration logic intoregisterRoutesto handle both global and route-specific middlewares.registerMiddlewareshelper function.