Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CreateDashboard Script #26

Merged
merged 10 commits into from
Feb 21, 2024
Merged

Update CreateDashboard Script #26

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4860af3
fix(createDashboard): use env var for host
ardelato Feb 14, 2024
5acb580
feat(createDashboard): add alerts for query value widget
ardelato Feb 14, 2024
6415127
feat(createDashboard): create request for the query value widget
ardelato Feb 14, 2024
263a93d
fix(createDashboard): fix the queries for the widgets
ardelato Feb 14, 2024
097c6b6
feat(createDashboard): add query value widget function
ardelato Feb 14, 2024
ccc9caa
feat(createDashboard): add layout parameter for widgets
ardelato Feb 14, 2024
e957553
feat(createDashboard): add query value widgets to iteration
ardelato Feb 14, 2024
0883ef5
feat(createDashboard): add custom link for timeseries
ardelato Feb 14, 2024
ba54cde
fix(createDashboard): fix comparator value units
ardelato Feb 14, 2024
b03cde2
fix(createDashboard): fix alert display type naming convention
ardelato Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 96 additions & 5 deletions src/scripts/createDashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const INSPECT_LIST = URLS;
const AUDITS = lhConfig.settings.onlyAudits || [];

// Auditname -> {warning: "warning value", alert: "alert value"}
const ALERT_MARKERS = {
const ALERT_MARKERS_TIMESERIES = {
'largest-contentful-paint': {
"warning": "2500 < y < 4000",
"alert": "y > 4000",
Expand All @@ -42,22 +42,113 @@ const ALERT_MARKERS = {
"alert": "y > 5.8",
},
};
const ALERT_MARKERS_QUERY_VALUE = {
'largest-contentful-paint': [
{
"comparator": ">",
"value": 4000,
"palette": "white_on_red"
},
{
"comparator": ">=",
"value": 2500,
"palette": "white_on_yellow"
},
{
"comparator": "<",
"value": 2500,
"palette": "white_on_green"
}
],
'first-contentful-paint': [
{
"comparator": ">",
"value": 3,
"palette": "white_on_red"
},
{
"comparator": ">=",
"value": 1.8,
"palette": "white_on_yellow"
},
{
"comparator": "<",
"value": 1.8,
"palette": "white_on_green"
}
],
'cumulative-layout-shift': [
{
"comparator": ">",
"value": 0.25,
"palette": "white_on_red"
},
{
"comparator": ">=",
"value": 0.1,
"palette": "white_on_yellow"
},
{
"comparator": "<",
"value": 0.1,
"palette": "white_on_green"
}
],
'total-blocking-time': [
{
"comparator": ">",
"value": 600,
"palette": "white_on_red"
},
{
"comparator": ">=",
"value": 200,
"palette": "white_on_yellow"
},
{
"comparator": "<",
"value": 200,
"palette": "white_on_green"
}
],
'speed-index': [
{
"comparator": ">",
"value": 5.8,
"palette": "white_on_red"
},
{
"comparator": ">=",
"value": 3.4,
"palette": "white_on_yellow"
},
{
"comparator": "<",
"value": 3.4,
"palette": "white_on_green"
}
],
};

function fetchAlertMarkersForAudit(auditName: string) {
return ALERT_MARKERS.hasOwnProperty(auditName) ? [
function fetchTimeseriesAlertMarkersForAudit(auditName: string) {
return ALERT_MARKERS_TIMESERIES.hasOwnProperty(auditName) ? [
{
"label": "Alert",
"value": ALERT_MARKERS[auditName].alert,
"value": ALERT_MARKERS_TIMESERIES[auditName].alert,
"display_type": "error dashed"
},
{
"label": "Warning",
"value": ALERT_MARKERS[auditName].warning,
"value": ALERT_MARKERS_TIMESERIES[auditName].warning,
"display_type": "warning dashed"
}
] : []
}

function fetchQueryValueAlertMarkersForAudit(auditName: string) {
return ALERT_MARKERS_QUERY_VALUE.hasOwnProperty(auditName) ? ALERT_MARKERS_QUERY_VALUE[auditName] : []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see us using hasOwnProperty in a few places. Can't we simplify this?

return ALERT_MARKERS_QUERY_VALUE[auditName] ?? []

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, this whole script could be improved and simplified. I thought about refactoring it by using a Factory design pattern but that is quite the over haul for the scope of the issue.

main...testing-factory-pattern-for-create-dashboards-script

}

function createWidgetRequestsForMetric(audit: string, pageType: string): v1.TimeseriesWidgetRequest[] {
return [
{
Expand Down