Initial branch #1
Conversation
ehoogerbeets
commented
Oct 28, 2024
•
ehoogerbeets
commented
- added circleci config that runs only the tests for the part of the monorepo that you have changed (may not work fully yet)
- added a README.md that describes how to use this circleci stuff
- builds can be seen at https://app.circleci.com/pipelines/github/iLib-js/ilib-mono
- added the first cut of ilib-lint. This has not been modified from v2.5.0 yet and does not have branches and such copied yet. It is just there to test the circleci stuff. I'll add the branches and such later.
- ilib-lnit is in the packages directory. If we choose a package manager that needs it in another directory, we can move it then
See if we can get it to work
| - run: | ||
| name: Setup | ||
| command: | | ||
| rm -rf node_modules package-lock.json |
There was a problem hiding this comment.
| rm -rf node_modules package-lock.json | |
| rm -rf node_modules package-lock.json yarn.lock |
| name: Setup | ||
| command: | | ||
| rm -rf node_modules package-lock.json | ||
| npm install |
There was a problem hiding this comment.
Is there a reason for using npm instead of yarn?
Shall we use yarn instead?
Since we're creating brand new repo, I'd love to stick to modern stack whenever possible.
There was a problem hiding this comment.
Few quotes from yarn creators:
The npm client installs dependencies into the
node_modulesdirectory non-deterministically. This means that based on the order dependencies are installed, the structure of anode_modulesdirectory could be different from one person to another. These differences can cause “works on my machine” bugs that take a long time to hunt down.
Yarn resolves these issues around versioning and non-determinism by using lockfiles and an install algorithm that is deterministic and reliable.
(...) Yarn is able to parallelize operations, which maximizes resource utilization and makes the install process faster.
| @@ -0,0 +1,184 @@ | |||
| # copied from https://github.com/circle-makotom/circle-advanced-setup-workflow/blob/main/.circleci/config.yml | |||
There was a problem hiding this comment.
Do we need all of these? How about starting with minimal setup and adding things as we go, once they're required?
| workflows: | ||
| version: 2 | ||
| test-all-node-version: | ||
| jobs: |
There was a problem hiding this comment.
Why those Node.js versions and not the others?
| docker: | ||
| - image: cimg/base:stable | ||
| steps: | ||
| - run: echo "No updates have been made to any of the subpackages" |
There was a problem hiding this comment.
| - run: echo "No updates have been made to any of the subpackages" | |
| - run: echo "No updates have been made to any of the packages" |
| @@ -0,0 +1,8 @@ | |||
| version: 2.1 | |||
There was a problem hiding this comment.
When is this used? I cannot find usages with search.
