Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.1 Package Shift #1

Merged
merged 3 commits into from
Jan 12, 2018
Merged

Laravel 5.1 Package Shift #1

merged 3 commits into from
Jan 12, 2018

Conversation

amenk
Copy link
Member

@amenk amenk commented Jan 12, 2018

This pull request includes the changes for upgrading your Laravel Package to Laravel 5.1. Feel free to commit any additional changes to the shift-5872 branch.

Before merging, you should:

  • Checkout the shift-5872 branch
  • Review all pull request comments for additional changes
  • Update your dependencies for Laravel 5.1
  • Run composer update (if the pre-scripts fail, add --no-scripts)
  • Thoroughly test your code

This Shift is still in beta. If there were changes you feel could have been automated, please send your feedback to [email protected] or via Twitter.

The Laravel framework adopts the PSR-2 coding style in version 5.1.
Laravel apps *should* adopt this coding style as well. Read the
[PSR-2 coding style guide][1] for more details and check out [PHPCS][2]
to use as a code formatting tool.

[1]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
[2]: https://github.com/squizlabs/PHP_CodeSniffer
Laravel 5 adopted the short array syntax which became available in
PHP 5.4.
@amenk
Copy link
Member Author

amenk commented Jan 12, 2018

❌ Laravel 5.1 requires PHP 5.5.9+. You have an existing requirement for PHP in your composer.json. Ensure the version is >=5.5.9.

@amenk amenk merged commit 2be31cf into laravel-5 Jan 12, 2018
@SidneySaints SidneySaints deleted the shift-5872 branch January 24, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants