remove direct polymorphic() calls
#2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
smmr-dn
and removed request for
a team
r100-stack
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This removes the ability to call
polymorphic()directly. Allpolymorphic()calls have been replaced withpolymorphic.div().The main reason for this PR is to allow using
polymorphic()for different capabilities (#2196). I'm still experimenting with it and might ultimately decide to go with a different API. Regardless, havingpolymorphic()be an alias topolymorphic.div()doesn't provide any real benefit and it's simpler to only have one way of writing it.Testing
Removed the test for
polymorphic().Docs
N/A. Fully internal change.