Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme bridge to v5.0.0 #2373

Merged
merged 98 commits into from
Feb 11, 2025
Merged
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
a14d7a3
🛫
r100-stack Dec 6, 2024
17f2f4d
🛫
r100-stack Dec 16, 2024
cd6e72c
Leftover
r100-stack Dec 16, 2024
c9ffbb6
Merge branch 'main' into r/private-css-vars
r100-stack Dec 16, 2024
7a1a845
Partial fixes
r100-stack Dec 16, 2024
44d3e9b
Fixed theme toggles
r100-stack Dec 17, 2024
8786e7a
Merge branch 'main' into r/private-css-vars
r100-stack Dec 17, 2024
4b0836c
Merge branch 'r/private-css-vars' into r/bridge
r100-stack Dec 17, 2024
7b35137
Fixes
r100-stack Dec 17, 2024
950f796
Fixes
r100-stack Dec 17, 2024
8b213e9
Cleanup
r100-stack Dec 17, 2024
ca20e05
Simplification
r100-stack Dec 17, 2024
ee51d4b
Leftover
r100-stack Dec 17, 2024
10a0d16
Merge remote-tracking branch 'origin/main' into r/private-css-vars
r100-stack Dec 17, 2024
3303613
Merge branch 'r/private-css-vars' into r/bridge
r100-stack Dec 17, 2024
ba8e6df
nit
r100-stack Dec 18, 2024
96e5c21
Merge branch 'main' into r/private-css-vars
r100-stack Dec 18, 2024
7c778a1
Merge remote-tracking branch 'origin/r/private-css-vars' into r/bridge
r100-stack Dec 18, 2024
864fbe2
`pnpm-lock.yml`
r100-stack Dec 18, 2024
808056b
Comments
r100-stack Dec 18, 2024
cd9dedb
Remove `*` by unlayering
r100-stack Dec 18, 2024
a216d1b
no dep on
r100-stack Dec 18, 2024
666f197
Comments
r100-stack Dec 19, 2024
2e3e503
Fix layer order in css workshop
r100-stack Dec 19, 2024
1375402
Re-add variables dep in react-workshop
r100-stack Dec 19, 2024
65a0cba
Into separate layer
r100-stack Dec 19, 2024
7733e97
Fix order
r100-stack Dec 19, 2024
535ff3f
Text color from base to faded.
r100-stack Dec 19, 2024
0a3b283
Border's "subtle" improvements.
r100-stack Dec 19, 2024
677806b
Removed override for background-transparent-hover and field backgroun…
r100-stack Dec 19, 2024
f987e8b
Button improvements.
r100-stack Dec 19, 2024
c1c865b
Reorder bridge components overrides.
r100-stack Dec 19, 2024
d5910a4
Breadcrumbs remove overrides.
r100-stack Dec 19, 2024
2be9fa8
Testing and simplifications
r100-stack Dec 19, 2024
1eb5b25
Contrast improvements, TODOs
r100-stack Dec 20, 2024
237c1a7
Simplification
r100-stack Dec 20, 2024
de35da6
Merge branch 'r/private-css-vars' into r/bridge
r100-stack Dec 20, 2024
c45806f
Backgrounds, status borders, non-current breadcrumbs
r100-stack Dec 20, 2024
2eb99bf
Button group fix
r100-stack Dec 20, 2024
4ccd98c
scoping, few hsl variables
r100-stack Dec 20, 2024
b9d90ce
HSL, fix tree selection background and others.
r100-stack Dec 20, 2024
55fbde0
nit
r100-stack Dec 20, 2024
9307ef9
Bumping to dev version.
r100-stack Dec 20, 2024
2199938
`future.themeBridge` prop
r100-stack Dec 24, 2024
3dea59e
Comments
r100-stack Dec 24, 2024
a338de9
`bridge.scss` simplification
r100-stack Dec 24, 2024
04dd4a1
Leftover
r100-stack Dec 24, 2024
fa01ca3
Merge branch 'main' into r/private-css-vars
r100-stack Dec 24, 2024
52020e8
Other comments
r100-stack Dec 24, 2024
af04c6d
Merge branch 'r/private-css-vars' into r/bridge
r100-stack Dec 24, 2024
162008f
Leftover
r100-stack Dec 24, 2024
52252cf
Bump `@astrojs/react`
r100-stack Dec 24, 2024
0bcb005
Pass `future` to portal container
r100-stack Dec 24, 2024
46eb69d
More comments
r100-stack Dec 24, 2024
be0762e
Remove unnecessary hardcoded theme
r100-stack Dec 24, 2024
1412dac
More comments in bridge
r100-stack Dec 24, 2024
fc42aea
Default prop value for `future`
r100-stack Dec 24, 2024
5ac59aa
Update `itwinui-react` dev version
r100-stack Dec 24, 2024
bf85969
Merge branch 'main' into r/private-css-vars
r100-stack Jan 21, 2025
338b866
Merge branch 'r/private-css-vars' into r/bridge
r100-stack Jan 21, 2025
10dbfcd
Comment
r100-stack Jan 21, 2025
98ad57a
Descriptive comments
r100-stack Jan 21, 2025
c26461a
Minimize CSS workshop changes
r100-stack Jan 21, 2025
36b8df8
Next playground, website
r100-stack Jan 29, 2025
1e2c424
Other 3 playgrounds, a11y
r100-stack Jan 29, 2025
3ec5ddd
Workshops, portal, sandbox
r100-stack Jan 29, 2025
683ed0e
Merge branch 'main' into r/upgrade-deps
r100-stack Jan 30, 2025
cbc5d9c
🛫
r100-stack Jan 31, 2025
58725e8
Merge branch 'r/toasts-test-flakiness' into r/upgrade-deps
r100-stack Jan 31, 2025
1ccef36
Merge branch 'main' into r/private-css-vars
r100-stack Feb 3, 2025
2616758
Reverted breadcrumbs change
r100-stack Feb 3, 2025
3bdec20
Merge branch 'r/private-css-vars' into r/bridge
r100-stack Feb 3, 2025
e601c4b
Comments
r100-stack Feb 3, 2025
32102eb
Bump iTwinUI-react v5 alpha
r100-stack Feb 3, 2025
907bf73
Merge remote-tracking branch 'origin/main' into r/bridge
r100-stack Feb 3, 2025
fa0a6bb
3.17.0-dev.2
r100-stack Feb 3, 2025
30752e8
ThemeProvider as Root
r100-stack Feb 4, 2025
6c2f574
`outline: none`
r100-stack Feb 4, 2025
d1bba65
Use v5 Root only when needed
r100-stack Feb 4, 2025
e9e1953
Comments about changeset
r100-stack Feb 4, 2025
286fec8
Typo
r100-stack Feb 4, 2025
598c557
Fix audit
r100-stack Feb 4, 2025
a536cc8
Revert dev version
r100-stack Feb 4, 2025
280b4ed
Fixed css-workshop tests
r100-stack Feb 4, 2025
db4c844
Fix default themeBridge in react-workshop
r100-stack Feb 5, 2025
adbffde
Merge branch 'main' into r/bridge
r100-stack Feb 5, 2025
eb61b9d
pnpm-lock
r100-stack Feb 5, 2025
ab88842
Merge branch 'main' into r/upgrade-deps
r100-stack Feb 5, 2025
c72ab82
Merge branch 'r/upgrade-deps' into r/bridge
r100-stack Feb 5, 2025
4b06da8
Merge branch 'main' into r/bridge
r100-stack Feb 7, 2025
0f66326
Leftover
r100-stack Feb 7, 2025
fa4a6b1
Comments
r100-stack Feb 7, 2025
e4b06ae
Update .changeset/few-llamas-smell.md
r100-stack Feb 10, 2025
41d0a30
Merge branch 'main' into r/bridge
r100-stack Feb 10, 2025
24ca3cf
Merge branch 'main' into r/bridge
r100-stack Feb 10, 2025
210fec9
Fix lock file. Use react 19.
r100-stack Feb 10, 2025
40592f7
Merge branch 'main' into r/bridge
r100-stack Feb 10, 2025
14a42fa
JSDocs correction
r100-stack Feb 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Border's "subtle" improvements.
Blockquote remove override.

Co-authored-by: Mayank <[email protected]>
  • Loading branch information
r100-stack and mayank99 committed Dec 19, 2024
commit 0a3b283a38ed33a6c78297a610b6582730cf078a
18 changes: 4 additions & 14 deletions packages/itwinui-css/src/bridge.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright (c) Bentley Systems, Incorporated. All rights reserved.
// See LICENSE.md in the project root for license terms and full copyright notice.
// TODO: Make it alphabetical

:where([data-iui-bridge='true']) {
--iui-color-white: var(--kiwi-color-static-white);
@@ -40,15 +41,12 @@
--iui-color-border-hover: var(--iui-color-border);
--iui-color-border-disabled: var(--kiwi-color-border-glow-on-surface-disabled);

--iui-color-border-subtle: var(
--iui-color-border
); /* TODO: Not sure. E.g. --kiwi-color-border-neutral-muted for Surface is an issue since
/* TODO: Not sure. E.g. --kiwi-color-border-neutral-muted for Surface is an issue since
border-neutral-muted === bg-neutral-base. So border is invisible. So, should we use -faded instead? Same problem I
think with Divider (iui-color-border-subtle) inside of a Surface (iui-color-background) */
--iui-color-border-subtle: var(--kiwi-color-border-neutral-base);

--iui-color-border-accent: var(
--kiwi-color-border-accent-base
); /* TODO: border-accent-base or border-accent-strong? */
--iui-color-border-accent: var(--kiwi-color-border-accent-strong);

--iui-color-icon-accent: var(--kiwi-color-icon-accent-base);
--iui-color-icon-informational: var(--kiwi-color-icon-info-base);
@@ -424,14 +422,6 @@
border-color: var(--kiwi-color-border-neutral-faded);
}

/* ---------------------------------------------------------------------------- */
/* Blockquote */

.iui-blockquote {
/* TODO: Not sure because the subtle border for the other three edges are not subtle. */
border-inline-start-color: var(--kiwi-color-border-neutral-faded);
}

/* ---------------------------------------------------------------------------- */
/* Icon */