Add missing flex-shrink: 0 to iui-button-icon
#2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
mayank99
approved these changes
Jan 9, 2025
Sounds good, added (78617f4). |
smmr-dn
approved these changes
Jan 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
SideNavigationbutton icons appear correctly in iTwinUI v3. However, in #2373, we noticed that theSideNavigationbutton icons were collapsing to 0 width. I believe that started happening after using iTwinUI v5's reset layer.Upon investigation, @mayank99 and I realized that a
flex-shrink: 0was missing oniui-button-icon. This PR adds that missing CSS declaration.Testing
SideNavigationbutton icons in iTwinUI v3 continue to appear correctly.SideNavigationbutton icons in iTwinUI v3 + theme bridge (#2373) now appear correctly:Docs
Added a changeset even though the change was small (#2396 (comment)).