Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps in non-package workspaces #2418

Merged
merged 9 commits into from
Feb 6, 2025
Merged

Upgrade deps in non-package workspaces #2418

merged 9 commits into from
Feb 6, 2025

Conversation

r100-stack
Copy link
Member

@r100-stack r100-stack commented Jan 29, 2025

Changes

PR 1 in PR chain for #2387 (React 19 support). (PR 1: this PR, PR 2: #2424, PR 3: #2387).

Upgraded a couple of deps in non-package workspaces to help with React 19 support since some packages' older versions might not support React 19. Thus, to be safe, this helper PR upgrades some deps that may have fixed some problems in #2387 during its development.

Even this PR doesn't help a lot in the React 19 support, it wouldn't hurt to upgrade the deps to avoid potential issues. This is especially true since these upgrades are in non-package workspaces and so don't affect the user.

Testing

  • CI passing
  • Builds passing
  • Manually verify that the workspaces are opening correctly

Docs

N/A since all the upgrades are in non-package workspaces and thus won't affect the user.

@r100-stack r100-stack self-assigned this Jan 29, 2025
@r100-stack r100-stack changed the base branch from main to r/toasts-test-flakiness January 31, 2025 20:38
Base automatically changed from r/toasts-test-flakiness to main February 4, 2025 21:45
@r100-stack r100-stack marked this pull request as ready for review February 6, 2025 14:07
@r100-stack r100-stack requested a review from a team as a code owner February 6, 2025 14:07
@r100-stack r100-stack requested review from mayank99 and smmr-dn and removed request for a team and smmr-dn February 6, 2025 14:07
@r100-stack r100-stack changed the title Upgrade deps Upgrade deps in non-package workspaces Feb 6, 2025
@r100-stack r100-stack merged commit 43d2be0 into main Feb 6, 2025
18 checks passed
@r100-stack r100-stack deleted the r/upgrade-deps branch February 6, 2025 22:23
This was referenced Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants