Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 19 #5801

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

s-sbo
Copy link

@s-sbo s-sbo commented Jan 27, 2025

Description
Updates Slate's React version to 19.0.0.

Context

  • useRef now requires an argument
    • All useRef usage now has an initial argument, with relevant hooks updated to explicitly handle passed refs which may be falsy.
    • Removed depreciated MutableRefObject
  • React 19 supports ref as a prop and forwardRef will be depreciated and removed in future.
    • All forwardRef usage has been refactored.
    • (I thought about leaving this for a later refactor as I don't know much about how version bumps are managed on packages like this but in the end the new API reduces so much boilerplate it seemed worth it.)
  • Minor housekeeping
    • Updated types, removed unused imports, fixed 404'ing images in images example, minor updates to some other examples

Checks

  • The new code matches the existing patterns and styles.
  • [] The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: e170f95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant