This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
Proxy the dependencies in the URL generation command #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Magento 2.1.8+ CLI commands are constructed when the CLI client is invoked. Additionally, DI will construct any objects that those commands type in their constructors, so on and so fourth down the stack. The problem is, this extension may exist in an environment in which the store is not yet installed, and the database is thus unavailable. A common place this is used is in 2.1.x in CI, as the database is required in order to generate static content. This commit proxies the dependencies of this constructor, such that the constructor can be used (and thus appear in the CLI menu) but not invoked while the store is not installed.
|
Notes are on the commit; Still doing some sanity checking on this. |
|
sanity checking complete. fixed the bug i had, didn't explode. #shipit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.