add CHECK_NAME_DUPLICATES feature
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
approved these changes
Sep 5, 2024
handler.ts
Outdated
| { customResponse: cur, primaryResponse: prev }, | ||
| // Default to false | ||
| CHECK_NAME_DUPLICATES !== 'false' | ||
| // convertQSPToGeocoderArgs(event.queryStringParameters)?.focusPoint |
There was a problem hiding this comment.
Good catch thanks
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
requested changes
Sep 10, 2024
| @@ -112,13 +112,15 @@ describe('response merging', () => { | |||
| customResponse: CUSTOM_RESPONSE, | |||
| primaryResponse: GEOCODE_EARTH_RESPONSE | |||
| }, | |||
| true, | |||
There was a problem hiding this comment.
can we get a test that tests this with false?
There was a problem hiding this comment.
I tried but couldn't do it in any way that made sense. This test tests for something completely different. We could add an entire new test case but this is a really weird edge case so I'm tempted to add a TODO here instead?
There was a problem hiding this comment.
I'd be fine with a TODO.
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Sep 17, 2024
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
deleted the
support-disabling-name-based-dupe-checking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new feature
CHECK_NAME_DUPLICATESin the config which disables name-based duplicate checking. This is helpful when your GTFS has common names in it.