feat: read attributes from root node of XML documents #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joel-hanson
reviewed
Sep 2, 2024
This commit modifies the Converter so that it now captures attributes from the root nodes of XML documents. The logic change for the Converter is relatively minor (read the attributes from the XML reader before starting to recursively traverse the document) so most of the changes in this commit are to add a few variations of test to verify the new behaviour. Signed-off-by: Dale Lane <[email protected]>
dalelane
force-pushed
the
root-node-attributes
branch
from
fc63703
to
bf7ad5d
Compare
|
rebased to bring in the update from #5 - hopefully that will fix the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit modifies the Converter so that it now captures attributes from the root nodes of XML documents. The logic change for the Converter is relatively minor (read the attributes from the XML reader before starting to recursively traverse the document) so most of the changes in this commit are to add a few variations of test to verify the new behaviour.
Also updated dependencies to bring them up to date.
Type of change
How Has This Been Tested?